sdedic opened a new pull request, #7558: URL: https://github.com/apache/netbeans/pull/7558
The `mvnw` wrapper contains a subtle bug, which triggers when -running on UNIXes, **and** - there's a space in the project path, **and** - wrapper is invoked using full path In that case, the wrapper fails to locate its basedir and loops indefinitely, not even launching Maven itself. Regular user just uses `./mvnw` or `../mvnw` from the terminal, and is not affected. Sadly NB uses full path to invoke the wrapper. The bug was [fixed an year ago in maven-wrapper, line 173](https://github.com/apache/maven-wrapper/commit/7840c9036eb6e082f53ff6c18c87c82e21819e02#diff-9f09d06998a17f35256c5fe39732f2acd724bde0eb02e2cff65479ff55e53170L173) but since the wrapper script is committed in many git repositores, NB should work well even with the buggy version. This PR *relativizes* the wrapper path to the execution directoy (either the project dir, or the reactor dir) which works around this bug: one would have to have spaces in path to maven module **within** the project, which is quite unlikely (and such project would not be usable even from the commandline). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
