neilcsmith-net commented on code in PR #7548:
URL: https://github.com/apache/netbeans/pull/7548#discussion_r1678241136
##########
java/java.hints/src/org/netbeans/modules/java/hints/infrastructure/JavaErrorProvider.java:
##########
@@ -200,25 +202,55 @@ private static List<CodeAction>
convertFixes(ErrorDescription err, Consumer<Exce
}
}
- List<Fix> fixes = sortFixes(lfl.getFixes());
+ List<Fix> baseFixes = lfl.getFixes();
+
+ baseFixes = sortFixes(baseFixes);
+
+ List<Pair<Fix, Boolean>> fixesAndSubfixes = new ArrayList<>(); // true
if main fix
+
+ for (Fix f : baseFixes){
+ fixesAndSubfixes.add(Pair.of(f, true));
+
+ try {
+ Class<?> controller =
Class.forName("org.netbeans.modules.editor.hints.HintsControllerImpl",
+ false,
+
ErrorDescription.class.getClassLoader());
+ Method getSubfixes =
controller.getDeclaredMethod("getSubfixes", Fix.class);
Review Comment:
> putting getSubfixes to the API, which is problematic, as spi.editor.hints
does not have any API currently,
To clarify, because it doesn't have any API packages as opposed to public
packages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
