sdedic commented on code in PR #7595:
URL: https://github.com/apache/netbeans/pull/7595#discussion_r1683925445
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/OCINode.java:
##########
@@ -124,10 +129,12 @@ public Node.Handle getHandle() {
private final class RefreshListener implements PropertyChangeListener {
@Override
public void propertyChange(PropertyChangeEvent evt) {
- if ("referenceName".equals(evt.getPropertyName())) {
+ if ("referenceName".equals(evt.getPropertyName()) //NOI18N
+ || "publicIp".equals(evt.getPropertyName())) { //NOI18N
Review Comment:
Now where there's fireDisplayNameChange in both branches - would it be too
bad to call `refresh` + `fireDisplayNameChange` for all cases ?
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/compute/ComputeInstanceNode.java:
##########
@@ -45,13 +56,69 @@ public ComputeInstanceNode(ComputeInstanceItem instance) {
setName(instance.getName());
setDisplayName(instance.getName());
setIconBaseWithExtension(COMPUTE_INSTANCE_ICON);
- setShortDescription(Bundle.CoputeInstanceDesc(instance.getName()));
+ setShortDescription(Bundle.CoputeInstanceDesc(
+ instance.getName(),
+ instance.getPublicIp(),
+ instance.getUsername(),
+ instance.getProcessorDescription()
+ ));
}
public static NodeProvider<ComputeInstanceItem> createNode() {
- return ComputeInstanceNode::new;
+ return (instance) -> {
+ update(instance);
+ return new ComputeInstanceNode(instance);
+ };
}
+
+
+ static public void update(ComputeInstanceItem instance) {
Review Comment:
Not checked alive, but make sure this runs in other thread than EDT that
usually expands nodes and a different thread than LSP event one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
