jtulach commented on PR #7579: URL: https://github.com/apache/netbeans/pull/7579#issuecomment-2240946735
> freeze for NB23 was moved from 15th to the 26th (next Friday) so there is time to review/test this properly without rushing anything in https://lists.apache.org/thread/pr3dnjdkot8kny9g2htqlpcg1s9f9t45 Thanks for letting me know. I believe both NetBeans as well as VSCode are working fine with the current state of this PR: - Matthias's [debugging scenario](https://github.com/apache/netbeans/pull/7579#issuecomment-2236516957) works and there are no duplications - VSCode shows hints in `Dummy.java` file, can debug, offers code completion I am confident things are OK this time. Unless I hear objections, I plan to integrate early next week. > I think the main discovery here remains that none of the existing tests picked any of the problems up. Would be good to check why that happened (is the module not loaded or something similar?). E.g regression tests for double occurrence of hint annotations might be something we could add (but I would be surprised if they weren't there yet). Hints are certainly tested, but I think they are tested via "unit tests". Such kind of tests can detect missing functionality of own module, but cannot detect extra functionality of completely different module. Such an integration test would need `NbModuleSuite` with all enabled modules - I don't think NetBeans has such a test these days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
