ShadowOfLies commented on PR #7616: URL: https://github.com/apache/netbeans/pull/7616#issuecomment-2256797192
> There is a problem though: duplicated code. There is an almost identical dialog for types (ctrl+o), which likely going to need that link too (I hope "Go to Dialog Settings" do in fact apply to both dialogs). I had a quick look and "Go To Type" does make use of the same settings. I actually agree that the Go To Settings is pretty pointless apart from the Order By. My preference would be keeping the current change as-is (I don't like scope creep) and tackling the removal and cleanup of the `Go To Settings` properly, together with consolidating the 2 feature dialogs to reduce the duplication. This includes moving the order by to a checkbox. If we're in agreement about this being the way forward (@mbien @matthiasblaesing), then I'm happy to work on that next, since I haven't seen another issue that I was planning to pick up just yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
