neilcsmith-net commented on PR #7624: URL: https://github.com/apache/netbeans/pull/7624#issuecomment-2260204786
To follow up on the discussion thread, I'm inclined to -1 this change. The issue is fairly easy to work around - see https://github.com/apache/netbeans/discussions/7601#discussioncomment-10199892 My main concern with this PR is with "continue the startup process (maybe without having called the validate method)." If we have any module that relies on OSGi classes and does validation, a refactor of the module install could start silently bypassing validation rather than throwing the exception (correctly IMO given the current limitations). We should possibly find somewhere to better document this issue. Possibly catch and rethrow the `NoClassDefFoundRethrow` with explanatory text? There are limitations documented with the validation method, that also apply to class initialization time, that might be expanded on? I would also point out the "Most modules should not need this." in the docs of ModuleInstall. There's probably a better way to achieve what's desired in the application. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
