mbien commented on PR #7631:
URL: https://github.com/apache/netbeans/pull/7631#issuecomment-2267181276
made a small change since the `sortText` value for `FieldItem` wasn't cached.
I did also take another look at this and `LazySortText#charAt` was never
called before this change here, due to the fact that the `CharSequence` got
concatenated to other `Strings` using its default `toString()` method.
Now its called while `toString() `is building the String, which happens once
per item.
I think we should consider to remove `LazySortText` entirely at some later
point because of two reasons:
- there is no way to lazily concat multiple CharSequences, this would
require more utilities
- I highly doubt that smart charAt logic will outperform intrinsified
String comparison methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
