matthiasblaesing commented on code in PR #7635: URL: https://github.com/apache/netbeans/pull/7635#discussion_r1703374834
########## java/debugger.jpda.truffle/nbproject/project.properties: ########## @@ -16,7 +16,7 @@ # under the License. javac.compilerargs=-Xlint:unchecked -javac.source=1.8 +javac.release=11 Review Comment: I read a tad of irony into this. However there is an artifact `JPDATruffleBackend.jar` build as part of the build process for that module. For that compilation the the source and target values are hardcoded to 1.8: https://github.com/apache/netbeans/blob/a5fa02d5e704f77ad32bb0c85815120474331e3b/java/debugger.jpda.truffle/build.xml#L42-L47 The resulting jar indeed only holds class files with version 52 (JDK 8). From that perspective this looks sane to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
