jtulach commented on issue #7647: URL: https://github.com/apache/netbeans/issues/7647#issuecomment-2282667405
CCing @jlahoda, @ppisl, @dbalek.. > @troizet your analysis is spot on. The problem as I see it is, that #7579 removed the default registration of `JavaErrorProvider` in NetBeans IDE and registers it only in NetBeans VSCode. But that fix is incomplete, as the NB Codebase holds other `ErrorProvider` implementations, that need to be removed also. > ... > Some of these are covered, but they need to be checked. > > For PHP the errors flow through the `GsfErrorProvider`. Yes, the flow goes thru `GsfErrorProvider`. The `PHPLanguage` uses `@LanguageRegistration(mimeType=PHP_MIME_TYPE...)` registration which registers `ErrorProvider` as well as a Gsf own implementation that fills the `HintsCollector.setErrors`. I somehow need to find out in the `ErrorProviderBridge` that the delegation shouldn't happen. If we want to do it in really compatible way, then: - we need to differentiate between the providers written prior to #7579 - and providers that want to benefit from #7579 support > @jtulach can you provide a fix? #7659 is my attempt to make the #7579 support change as compatible as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
