sdedic opened a new pull request, #7705: URL: https://github.com/apache/netbeans/pull/7705
@mbien mentioned test failures in #7655, I've experienced them too in #7665 ([action run](https://github.com/apache/netbeans/actions/runs/10598938114/attempts/1)) and #7697 ([action run](https://github.com/apache/netbeans/actions/runs/10595857319/attempts/1)). I've "sort of" traced/guessed it to finalization of a reload: in the original code, the Future completes (which means it unblocks the test thread), then the reload formally ends (pending reload is removed). The test may be able to observe the still-running reload (nearing its end) during its `tearDown`. The order was chosen so that events are fired only after Future completion, so potential observers see the new state as completed/ready. The PR splits the "formal termination" of a pending reload from event delivery, so the sequence is now: - end the reload, potentially prepare the next one in the queue - complete the reload Future - deliver events and proceed with the next reload This sequence is actually better / more predictable for clients. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
