lahodaj commented on PR #7725:
URL: https://github.com/apache/netbeans/pull/7725#issuecomment-2326308520
I may be doing something wrong or misunderstanding something, but a few
comments/questions:
- when I try currently, I don't seem to get the effects for Java errors, but
I am getting this in the log:
```
java.lang.Exception: no NbCodeLanguageClient!
at
org.netbeans.modules.java.lsp.server.protocol.TextDocumentServiceImpl.runDiagnosticTasks(TextDocumentServiceImpl.java:1890)
at
org.netbeans.modules.java.lsp.server.protocol.TextDocumentServiceImpl.runDiagnosticTasks(TextDocumentServiceImpl.java:1873)
at
org.netbeans.modules.java.lsp.server.protocol.TextDocumentServiceImpl.access$500(TextDocumentServiceImpl.java:267)
at
org.netbeans.modules.java.lsp.server.protocol.TextDocumentServiceImpl$5.lambda$diagnosticChanged$0(TextDocumentServiceImpl.java:2179)
at
java.base/java.util.concurrent.CompletableFuture.uniRunNow(CompletableFuture.java:819)
at
java.base/java.util.concurrent.CompletableFuture.uniRunStage(CompletableFuture.java:803)
at
java.base/java.util.concurrent.CompletableFuture.thenRun(CompletableFuture.java:2227)
at
org.netbeans.modules.java.lsp.server.protocol.TextDocumentServiceImpl$5.diagnosticChanged(TextDocumentServiceImpl.java:2178)
at
org.netbeans.modules.java.lsp.server.protocol.ErrorsNotifier.notifyErrors(ErrorsNotifier.java:73)
at
org.netbeans.modules.java.lsp.server.protocol.Server$CustomIndexerTelemetryFactory.scanFinished(Server.java:1416)
at
org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.scanFinished(RepositoryUpdater.java:2518)
...
```
- the `ErrorsNotifier` seems to refresh diagnostics only for files for which
there's an entry in the index. But what if there was an error in the index, and
the error is fixed? As I read the code, the diagnostics will not be refreshed?
- what if there will be a lot of files with errors? Will this try to open
the Document for all of them, and do full diagnostic run for them,
parsing&attributing in the process?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
