matthiasblaesing commented on PR #7733: URL: https://github.com/apache/netbeans/pull/7733#issuecomment-2334317203
> The proposal herein is to respond not only for source launcher files as before, but also for enclosing directories up to the package hierarchy root. This will happen only if the root has already been recognized, so it should not alter cases where source file launcher is not used. I checked it and I think it does not work. Here is what I did: 1. Build NetBeans from this branch 2. Place breakpoints in `MultiSourceRootProvider.java`, lines 110 and 164 3. Remove `nbbuild/testuserdir` 4. Run "Debug" from the "Java File Launcher" project 5. Enable "Java SE" in the Plugin manager 6. Ensure there is a "test.java" file in your home directory 7. Open "Favorites" tab 8. Expand the "Home" node The breakpoint in line 164 is hit with the home directory as `root`. The letting the IDE continue running the breakpoint in line 110 is hit, reporting `true` for my home directory. I did not use the source file launcher, yet the file and the directory are now recognized. What is more I see similar reports as @mbien. I opened java files from a JDK checkout and see: ``` INFO [org.netbeans.modules.java.hints.WrongPackageSuggestion]: source cp is either null or does not contain the compiled source cp= INFO [org.netbeans.modules.java.hints.WrongPackageSuggestion]: source cp is either null or does not contain the compiled source cp= WARNING [org.netbeans.modules.java.source.tasklist.IncorrectErrorBadges]: Incorrect error badges detected, file=/home/matthias/src/jdk/src/java.desktop/unix/classes/sun/font/X11GB18030_1.java. WARNING [org.netbeans.modules.java.source.tasklist.IncorrectErrorBadges]: The file is not on its own source classpath, ignoring. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
