sdedic opened a new pull request, #7749: URL: https://github.com/apache/netbeans/pull/7749
When testing implementation of [adding OCI assets](https://github.com/apache/netbeans/blob/master/enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/DependencyUtils.java#L53), @petrovic-d discovered that the maven dependency gets duplicated, instead of ignored 2nd time `vault` dependency was added. It can be only reproduced if the LSP client starst up with a pom.xml that does not contain the dependency at all, it is added . And subsequent calls to `modifyDependencies` add it despite the option `Options.skipConflicts`. Surprisingly it was not because the pom.xml was not reparsed (so the IDE would "think" the dependency is still missing), or the duplicate detection in the dependency modification code failed, but the final save operation was done using `SaveCookie` and not remoted to the client, which means the old good "duplicating text" issue: - NBLS saves a file - LSP client detects a file change, makes a diff and interprets it as a change that needs to be reported to NBLS through `didChange` - NBLS edits its document, appending a change that was already applied -> 2nd occurrence In addition `LspApplyEditsImplementation` was incorrectly registered, so it was not found :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
