sid-srini commented on PR #7750: URL: https://github.com/apache/netbeans/pull/7750#issuecomment-2349882899
> On a (relatively) quick review, this seems OK to me. But, I would say the `convertToLineOnlyFolds` method is quite complex, and some tests would be desirable. Round-trip test (like those in `ServerTest`) would not be bad, but this method could be also tested in a unit-test way. E.g. the method could be package-private and static, and called directly from the test(?) Thanks @lahodaj for taking a quick look at this draft PR. I intended to add the unit tests before making it ready-for-review. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
