matthiasblaesing commented on code in PR #7716:
URL: https://github.com/apache/netbeans/pull/7716#discussion_r1763667812
##########
enterprise/payara.tooling/test/unit/src/org/netbeans/modules/payara/tooling/data/PayaraVersionTest.java:
##########
@@ -86,16 +86,17 @@ public void testToFullString() {
=
fullVersion.split(PayaraPlatformVersionAPI.SEPARATOR_PATTERN);
assertTrue(numbers != null && numbers.length == 4,
"Invalid count of version numbers");
- short major, minor, update, build;
+ short major, minor, update;
+ String build;
try {
major = Short.parseShort(numbers[0]);
minor = Short.parseShort(numbers[1]);
update = Short.parseShort(numbers[2]);
- build = Short.parseShort(numbers[3]);
+ build = numbers[3];
assertTrue(major == version.getMajor()
&& minor == version.getMinor()
&& update == version.getUpdate()
- && build == version.getBuild());
+ && (build == null ? version.getBuild() == null :
build.equals(version.getBuild())));
Review Comment:
```suggestion
&& Objects.equals(build, version.getBuild()));
```
##########
enterprise/payara.tooling/src/org/netbeans/modules/payara/tooling/data/PayaraPlatformVersion.java:
##########
@@ -387,7 +392,7 @@ public boolean equals(final PayaraPlatformVersionAPI
version) {
return this.major == version.getMajor()
&& this.minor == version.getMinor()
&& this.update == version.getUpdate()
- && this.build == version.getBuild();
+ && (this.build == null ? version.getBuild() == null :
this.build.equals(version.getBuild()));
Review Comment:
```suggestion
&& Objects.equals(this.build, version.getBuild()));
```
##########
enterprise/payara.micro/src/org/netbeans/modules/fish/payara/micro/project/resources/action-mapping.xml:
##########
@@ -30,7 +30,7 @@
<goal>compiler:compile</goal>
<goal>war:exploded</goal>
<goal>payara-micro:stop</goal>
- <goal>payara-micro:start</goal>
+ <goal>payara-micro:dev</goal>
Review Comment:
Will this cause problems for existing installations? The dev-Mojo is only 9
months old, so old projects might hold plugin versions, not supporting this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
