sdedic commented on PR #7769: URL: https://github.com/apache/netbeans/pull/7769#issuecomment-2360512766
This does not (now) have a workable solution IMHO; the `close` could be done, iff the process is running headless, or can be conditioned by 'branding API' which would default to "do not close" and NBLS distribution would brand it to close. But the problem is NOT just maven-specific, it's general, for all opened editor types: if the SaveCookie.save() is invoked, it modifies the on-disk file, LSP client might (and vscode does) recognize it as external modification and will inform LSP servers with `didChange` -- which actually causes the Document in NB become modified with duplicate contents. Most proper solution is to relay the actual write to file to the LSP client (quite hard), or "somehow" detect that the `didChange` actually originates from the save (also quite hard). But we should work on that somehow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
