mbien commented on code in PR #7776:
URL: https://github.com/apache/netbeans/pull/7776#discussion_r1775243554
##########
java/java.file.launcher/src/org/netbeans/modules/java/file/launcher/SingleSourceFileUtil.java:
##########
@@ -116,6 +118,10 @@ public static Process compileJavaSource(FileObject
fileObject, JavaPlatform jdk)
if (!vmOptions.isEmpty()) {
compileCommandList.addAll(Arrays.asList(vmOptions.split(" ")));
//NOI18N
}
+ vmOptions =
NbPreferences.forModule(SingleSourceFileUtil.class).get("vmOptions",
"").trim(); // NOI18N
Review Comment:
this could be extracted since it is a constant which is used in 3 files
already.
This file has similar constants at L68, please rename to `globalVmOptions`
or possibly even use the same naming pattern as the other keys but prefix with
`global_`.
##########
java/java.file.launcher/src/org/netbeans/modules/java/file/launcher/Bundle.properties:
##########
@@ -16,3 +16,6 @@
# under the License.
OpenIDE-Module-Name=Java File Launcher
+GlobalSettingsPanel.vmLabel.text=VM Options:
Review Comment:
not sure what the usecase for this is, but please name it "Additional Global
VM Options" to communicate that those are flags which are appended to the
regular options. Otherwise users might think they _have_ to edit this setting
if they want to change the flags for a file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
