sdedic commented on code in PR #7869:
URL: https://github.com/apache/netbeans/pull/7869#discussion_r1798948156
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/CloudAssetsJavaCompletion.java:
##########
@@ -106,8 +107,12 @@ private Class<? extends OCIItem>
element2ReferenceClass(Element element) {
Elements elements = this.processingEnv.get().getElementUtils();
Types types = this.processingEnv.get().getTypeUtils();
tm = types.erasure(tm);
- TypeElement dataSource = elements.getTypeElement(DATA_SOURCE);
- if (dataSource != null && types.isAssignable(tm,
dataSource.asType())) {
+ TypeElement javaDataSource =
elements.getTypeElement(JAVA_DATA_SOURCE);
Review Comment:
Please double check this `java.sql.DataSource` type is valid -- I haven't
found it in JDK17-21 javadocs. There's just `javax.sql.DataSource` (although in
`java.sql` module) ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
