sdedic commented on code in PR #7877:
URL: https://github.com/apache/netbeans/pull/7877#discussion_r1805234942
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/items/OCIItem.java:
##########
@@ -188,4 +189,12 @@ public void fireRefNameChanged(String oldRefName, String
referenceName) {
changeSupport.firePropertyChange("referenceName", oldRefName,
referenceName);
}
+ public String getRegion() {
+ if (getRegionCode() != null) {
+ Region region = Region.fromRegionCodeOrId(getRegionCode());
Review Comment:
Maybe wrap in try-catch(IllegalArgumentException) - not sure if necessary,
`fromRegionCodeOrId` throws on invalid string.
##########
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/bucket/BucketItem.java:
##########
@@ -47,4 +53,18 @@ public int maxInProject() {
return Integer.MAX_VALUE;
}
+ @Override
+ public URL getURL() {
+ if (getKey().getValue() != null && getRegion() != null) {
+ try {
+ URI uri = new
URI(String.format("https://cloud.oracle.com/object-storage/buckets/%s/%s/objects?region=%s";,
Review Comment:
There are restrictions on name, namespace characters to create a Bucket, so
they do not need any URL encoding, right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
