t-gergely commented on PR #7833:
URL: https://github.com/apache/netbeans/pull/7833#issuecomment-2428745175

   > Hi, thanks for the contribution, but we require a valid email address in 
the commit header
   
   Yes, it was a bad idea to post this PR. Sorry. I probably should have 
attached a patch to an issue instead. You may commit the patch yourselves: I 
don't take credit for anything in it.
   
   > It would be good to generate test files for Javadoc 21+ alongside the ones 
introduced in the other PR
   
   I don't see a good reason for that. OTOH methods `testJavadoc8Class()` and 
`testJavadoc11Class()` also don't test the default constructors. Which has the 
consequence of the missing (cloned) test case for the current bug. So I 
recommend adding those tests, too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to