neilcsmith-net commented on PR #7928: URL: https://github.com/apache/netbeans/pull/7928#issuecomment-2449506982
Thanks @mbien Following the Slack conversation on this I've also been running NetBeans a lot with `TopSecurityManager.disable=true` and am mostly in favour of taking this way forward and removing a layer of complexity. Maybe call me a +0.8. > I know about 4 ways to trigger System.exit/Runtime.exit/Runtime.halt in current NetBeans ... (I don't want to put too much details here, as they can be sensitive.) Sensitive in what way? There are numerous ways that code running in the IDE VM, or even in an external process, can cause the IDE to exit (not to mention any other havoc). I still agree with Alan Bateman's comment on the enhancement request for adding an API to intercept exit - https://bugs.openjdk.org/browse/JDK-8199704 - "There has been several APIs prototyped around this and the conclusion each time is that it probably isn't the right thing to do. If ant or some other task runner is running a task that is hostile to running embedded/in-process then it should be launched into their own process/VM." IMO the benefits of intercepting System::exit are slight in comparison to the complexity introduced, were this the only reason for an agent ... > with webstart and SM removed, the clipboard swap trick will likely quit working too at some point The agent approach doesn't use the clipboard swap trick to implement this AFAIK. https://github.com/apache/netbeans/pull/3386/commits/8114562db52a62b359505097e813fc3f053beec6 The clipboard aspect of this is actually the aspect that concerns me the most. At the same time, given all the clipboard issues on Windows, removing all hacks might at least prove it's not our fault! :smile: > for the clipboard, there's "Paste from History" (Ctrl-Shift-D), which I believe depends on the ability to listen on the clipboard, and the standard Swing clipboard is not firing events, With a disabled SM the paste from history is _partly_ broken. It's possibly worth considering what the point of this feature is. If it's external and in-editor text, then that might be achievable without clipboard listening. There are of course now some events fired by the clipboard, but I assume not covering everything we want. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
