mbien commented on PR #7938: URL: https://github.com/apache/netbeans/pull/7938#issuecomment-2461912278
@neilcsmith-net > I think these are mostly unrelated concerns, and probably don't need to be discussed on this PR ... the reason why I brought this up at all is because thinking a bit ahead can sometimes save some work. > This is the only reason for switching for icons at all IMO. (...) Having the option to trade ~17 jars against one sounds like a good trade all by itself (esp in context of how dependencies are managed in the NB build) - even if jSVG would make no measurable difference. @eirikbakke > @mbien Good point, two libraries is kind of awkward... yep. Adding a dependency with overlapping functionality of an existing dependency should have a higher barrier. > Probably true. (I don't know exactly what the limitations with jSVG are compared to Batik.) same, I didn't take a look how JSVG compares to batik since I don't know batik very well, the readme of JSVG does list its supported and not supported features though. The failure mode would be also interesting since we could render a open-in-system button or something like that if it sees animation etc. Overall I don't really mind adding more batik jars if it is well motivated. But if we are going to remove them two weeks from now again it would be kinda awkward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
