petrovic-d commented on code in PR #7979:
URL: https://github.com/apache/netbeans/pull/7979#discussion_r1865368830
##########
java/java.lsp.server/vscode/src/testAdapter.ts:
##########
@@ -198,19 +213,41 @@ export class NbTestAdapter {
} else {
this.set(currentSuite, suite.state, undefined,
true);
}
+ this.set(currentModule,
this.calculateStateFor(currentModule), undefined, true);
}
}
break;
}
}
+ calculateStateFor(testItem: TestItem): 'passed' | 'failed' | 'skipped' |
'errored' {
+ let passed: number = 0;
+ testItem.children.forEach(item => {
+ const state = this.suiteStates.get(item);
+ if (state === 'enqueued' || state === 'failed') return state;
+ if (state === 'passed') passed++;
+ })
+ if (passed > 0) return 'passed';
Review Comment:
This is used to calculate end state for the module node -
https://github.com/apache/netbeans/blob/a3b539b8d2cd416f5ca54c800d6df2ca3bb590df/java/java.lsp.server/vscode/src/testAdapter.ts#L216,
thats why there is no `started` state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
