matthiasblaesing commented on code in PR #8057:
URL: https://github.com/apache/netbeans/pull/8057#discussion_r1885907060
##########
java/maven/src/org/netbeans/modules/maven/api/PluginPropertyUtils.java:
##########
@@ -652,21 +657,48 @@ public List<Dependency> build(Xpp3Dom configRoot,
ExpressionEvaluator eval) {
item.setGroupId(g.getValue());
item.setLocation(PROP_GROUP_ID,
(InputLocation)g.getInputLocation());
}
+
+ Dependency dependencyFromDependencyManagement = null;
+ if(dependencyManagement != null &&
dependencyManagement.getDependencies() != null) {
+ dependencyFromDependencyManagement =
+ dependencyManagement
+ .getDependencies()
+ .stream()
+ .filter(d -> {
+ return Objects.equals(item.getGroupId(),
d.getGroupId())
+ &&
Objects.equals(item.getArtifactId(), d.getArtifactId());
+ })
Review Comment:
Yeah and as I pushed an update I tried that variant, but it has a major
drawback: Automatic formatting without braces looks ugly, with brackets it is
good. Given how often I reformat, I prefer the stable format at at price of a
single line and some brackets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
