matthiasblaesing commented on code in PR #8036:
URL: https://github.com/apache/netbeans/pull/8036#discussion_r1898707648


##########
platform/core.network/src/org/netbeans/core/network/proxy/pac/impl/NbPacScriptEvaluator.java:
##########
@@ -196,6 +200,8 @@ public class NbPacScriptEvaluator implements 
PacScriptEvaluator {
     private static final String PAC_SOCKS5_FFEXT = "SOCKS5"; // Mozilla 
Firefox extension. Not part of original Netscape spec.
     private static final String PAC_HTTP_FFEXT = "HTTP"; // Mozilla Firefox 
extension. Not part of original Netscape spec.
     private static final String PAC_HTTPS_FFEXT = "HTTPS"; // Mozilla Firefox 
extension. Not part of original Netscape spec.
+    private static class RPSingleton { private static final RequestProcessor 
instance = new RequestProcessor(NbPacScriptEvaluator.class.getName(), 
Runtime.getRuntime().availableProcessors(), true, false); }
+    private static RequestProcessor getRequestProcessor() { return 
RPSingleton.instance; }

Review Comment:
   @subhash-arabhi thank you for the update. However you never answered the 
question: "Why the limit to number available processors?". Why does the 
intended throughput scale with the number or processors? From my POV that makes 
no sense to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to