mbien commented on code in PR #7938: URL: https://github.com/apache/netbeans/pull/7938#discussion_r1899232860
########## ide/svg/src/org/netbeans/modules/svg/navigation/SVGNavigatorPanel.java: ########## @@ -0,0 +1,208 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.netbeans.modules.svg.navigation; + +import com.github.weisj.jsvg.SVGDocument; +import com.github.weisj.jsvg.parser.SVGLoader; +import java.util.Collection; +import java.util.logging.Level; +import java.util.logging.Logger; +import javax.swing.JComponent; +import javax.swing.SwingUtilities; +import org.netbeans.modules.svg.SVGDataObject; +import org.netbeans.modules.svg.SVGViewerElement; +import org.netbeans.spi.navigator.NavigatorPanel; +import org.openide.filesystems.FileChangeAdapter; +import org.openide.filesystems.FileChangeListener; +import org.openide.filesystems.FileEvent; +import org.openide.filesystems.FileObject; +import org.openide.loaders.DataObject; +import org.openide.loaders.DataObjectNotFoundException; +import org.openide.util.*; + +/** + * + * @author christian lenz + */ [email protected]({ + @NavigatorPanel.Registration(mimeType = "image/svg+xml", displayName = "#Navigator_DisplayName") +}) +public class SVGNavigatorPanel implements NavigatorPanel { + + private static final Logger LOG = Logger.getLogger(SVGViewerElement.class.getName()); + + /** + * holds UI of this panel + */ + private SVGPreviewPanel panelUI; + /** + * template for finding data in given context. Object used as example, + * replace with your own data source, for example JavaDataObject etc + */ + private static final Lookup.Template<SVGDataObject> MY_DATA = new Lookup.Template<>(SVGDataObject.class); + /** + * current context to work on + */ + private Lookup.Result<SVGDataObject> currentContext; + /** + * listener to context changes + */ + private LookupListener contextListener; + /** + * Listens for changes on image file. + */ + private FileChangeListener fileChangeListener; + private long lastSaveTime = -1; + private DataObject currentDataObject; + private static final RequestProcessor WORKER = new RequestProcessor(SVGNavigatorPanel.class.getName()); + + @Override + public String getDisplayName() { + return NbBundle.getMessage(SVGNavigatorPanel.class, "Navigator_DisplayName"); + } + + @Override + public String getDisplayHint() { + return NbBundle.getMessage(SVGNavigatorPanel.class, "Navigator_DisplayHint"); + } + + @Override + public JComponent getComponent() { + if (lastSaveTime == -1) { + lastSaveTime = System.currentTimeMillis(); + } + if (panelUI == null) { + panelUI = new SVGPreviewPanel(); + } + return panelUI; + } + + @Override + public void panelActivated(Lookup context) { + // lookup context and listen to result to get notified about context changes + currentContext = context.lookup(MY_DATA); + currentContext.addLookupListener(getContextListener()); + // get actual data and recompute content + Collection<? extends SVGDataObject> data = currentContext.allInstances(); + currentDataObject = getDataObject(data); + + if (currentDataObject == null) { + return; + } + + if (fileChangeListener == null) { + fileChangeListener = new SVGFileChangeAdapter(); + } + currentDataObject.getPrimaryFile().addFileChangeListener(fileChangeListener); + setNewContent(currentDataObject); + } + + @Override + public void panelDeactivated() { + currentContext.removeLookupListener(getContextListener()); + currentContext = null; + if (currentDataObject != null) { + currentDataObject.getPrimaryFile().removeFileChangeListener(fileChangeListener); + } + currentDataObject = null; + } + + @Override + public Lookup getLookup() { + // go with default activated Node strategy + return null; + } + + private void setNewContent(final DataObject dataObject) { + if (dataObject == null) { + return; + } + + WORKER.post(() -> { + FileObject fo = dataObject.getPrimaryFile(); + + if (fo == null) { + return; + } + + if (panelUI == null) { + getComponent(); + } + + SVGLoader svgLoader = new SVGLoader(); + SVGDocument svgDocument = svgLoader.load(fo.toURL()); + + if (svgDocument == null) { + return; + } + + SwingUtilities.invokeLater(() -> panelUI.setSVG(svgDocument)); Review Comment: navigator needs to update even when svgDocument is null, otherwise it will keep displaying the last preview even if the selected file is broken - this could be confusing. The null check can be simply removed i think. manual test: switch between emptyfile.svg and good.svg and see what happens. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
