ExE-Boss commented on code in PR #8009:
URL: https://github.com/apache/netbeans/pull/8009#discussion_r1905087280
##########
platform/o.n.bootstrap/launcher/windows/jvmlauncher.cpp:
##########
@@ -249,7 +249,7 @@ bool JvmLauncher::startInProcJvm(const char *mainClassName,
const std::list<std:
for (list<string>::const_iterator it = options.begin(); it !=
options.end(); ++it, ++i) {
const string &option = *it;
logMsg("\t%s", option.c_str());
- if (option.find("-splash:") == 0 && hSplash > 0) {
+ if (option.find("-splash:") == 0 && hSplash != (void *) NULL) {
Review Comment:
Can this use `nullptr` instead of `NULL`, or is the used **C++** version too
old for that?
```suggestion
if (option.find("-splash:") == 0 && hSplash != nullptr) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
