junichi11 commented on code in PR #8139:
URL: https://github.com/apache/netbeans/pull/8139#discussion_r1911797587
##########
php/php.editor/src/org/netbeans/modules/php/editor/csl/SemanticAnalysis.java:
##########
@@ -228,94 +224,61 @@ public ASTNodeColoring(ASTNode identifier,
Set<ColoringAttributes> coloring) {
private final Map<UnusedIdentifier, ASTNodeColoring>
privateUnusedMethods;
// this is holder of blocks, which has to be scanned for usages in the
class.
private final Map<TypeInfo, List<Block>> needToScan = new HashMap<>();
-
private final Snapshot snapshot;
-
private final Model model;
-
- private Set<TypeElement> deprecatedTypes;
-
- private Set<MethodElement> deprecatedMethods;
-
- private Set<FieldElement> deprecatedFields;
-
- private Set<TypeConstantElement> deprecatedConstants;
-
- private Set<EnumCaseElement> deprecatedEnumCases;
-
- private Set<FunctionElement> deprecatedFunctions;
-
+ private final Program program;
+ private Set<QualifiedName> deprecatedTypes;
// last visited type declaration
private TypeInfo typeInfo;
-
- public SemanticHighlightVisitor(Map<OffsetRange,
Set<ColoringAttributes>> highlights, Snapshot snapshot, Model model) {
+ public SemanticHighlightVisitor(Map<OffsetRange,
Set<ColoringAttributes>> highlights, Snapshot snapshot, Model model, Program
program) {
this.highlights = highlights;
privateUnusedConstants = new HashMap<>();
privateFieldsUnused = new HashMap<>();
privateUnusedMethods = new HashMap<>();
this.snapshot = snapshot;
this.model = model;
+ this.program = program;
}
- private Set<TypeElement> getDeprecatedTypes() {
+ private Set<QualifiedName> getDeprecatedTypes() {
Review Comment:
Changed this to use `contains()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
