sdedic opened a new pull request, #8173:
URL: https://github.com/apache/netbeans/pull/8173

   NBLS action "run with Micronaut: dev mode" throws Internal error.
   
   PR #7979 introduced additional parameters for `.run.test`, `.debug.test`, 
`.run.single` and `.debug.single` - the `nestedClass` parameter was however 
added before `launchConfiguration`. 
   The relevant part in NBLS [which produce Code 
Lenses](https://github.com/apache/netbeans/blob/master/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/TextDocumentServiceImpl.java#L1338)
 was not adapted.
   
   The issue surfaces only if there are multiple project configurations in the 
project that provide Run/Debug action overrides; for Micronaut, the Micronaut 
module supplies a Project Configuration that (re) define Run action. The action 
is available from the editor code lens on the main class main() method, for 
example.
   It seems that a minimal change is to change the parameters added by PR #7979 
and order them after the existing ones, which allows pre-existing code to 
function. 
   
   I had to adapt the `testAdapter.ts` code that actually works with nested 
classes and uses the introduced parameter. There was one other usage in 
`testAdapters` but as it passed `udefined` to both configuration AND 
nestedclass, it can stay as it is.
   
   When reviewing, please consult also the original PR code - there are 2 
places that invoke the changed NBLS commands.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to