mbien commented on PR #8175: URL: https://github.com/apache/netbeans/pull/8175#issuecomment-2607631455
> We should also take a look at contrast accessibility and either work with Karl upstream or tweak ourselves, but again that's something that probably needs greater testing time than we have now. We could also consider making the `@foreground` color configurable via UI similar to the accent color. I would also like to contribute the editor theme I use but honestly I don't know how - modifying editor rendering settings changes a lot of files - extracting the config again looks time consuming. > The primary issue isn't how FlatLaf uses the accent colours, but that the suggested accent colours are not great choices for dark themes in the first place. right, but also that if the color is adjusted manually, some darkening values which work ok for the light theme, don't work for the dark theme anymore. E.g the darkened tab colors. There likely also need to be two "fade out" values for fonts, one for dark one for light. Things like https://github.com/apache/netbeans/pull/6695#issue-1992121504 or https://github.com/apache/netbeans/pull/7930#issuecomment-2519346062 are difficult to get right atm (this PR here helps though since it slightly increases the contrast for the dark theme). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
