neilcsmith-net commented on PR #7930: URL: https://github.com/apache/netbeans/pull/7930#issuecomment-2609323052
As I was asked for review, I'm not going to request changes (at least at this point), but I think the approach to colouring is wrong and over complicated. We should be looking to move all colouring code like this out of components. This should be a UI key. Something like a tab secondary foreground colour, that can use FlatLaf support for mixing and contrast, and the defaults on other LaFs. And would also ideally be used for the problematic versioning info. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
