junichi11 commented on code in PR #8177:
URL: https://github.com/apache/netbeans/pull/8177#discussion_r1926886803
##########
php/php.editor/src/org/netbeans/modules/php/editor/completion/CompletionContextFinder.java:
##########
@@ -228,6 +238,36 @@ final class CompletionContextFinder {
new Object[]{PHPTokenId.PHP_VARIABLE, PHPTokenId.PHP_TOKEN});
private static final List<String> SERVER_ARRAY_TOKENTEXTS =
Arrays.asList(new String[]{"$_SERVER", "["}); //NOI18N
+ private static final Set<PHPTokenId> BUILT_IN_TYPES = new
HashSet<>(Arrays.asList(
Review Comment:
Yes, we should use it. PHP editor is `javac.source=1.8`. We should change it
to `javac.release=17`. OK, I'll try changing it. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
