homberghp commented on code in PR #8197:
URL: https://github.com/apache/netbeans/pull/8197#discussion_r1930572549
##########
java/refactoring.java/test/unit/src/org/netbeans/modules/refactoring/java/test/RefactoringTestBase.java:
##########
@@ -109,33 +171,30 @@ protected void verifyContent(FileObject sourceRoot,
File... files) throws Except
while (!todo.isEmpty()) {
FileObject file = todo.remove(0);
- if (file.isData()) {
+ if (file.isData()) { // normal file
content.put(FileUtil.getRelativePath(sourceRoot, file),
copyFileToString(FileUtil.toFile(file)));
- } else {
+ } else { //folder?
Review Comment:
From the `org.openide.filesystems.FileObject` it follows that `!isData ==
isFolder`, more or less
##########
java/refactoring.java/test/unit/src/org/netbeans/modules/refactoring/java/test/RefactoringTestBase.java:
##########
@@ -400,7 +463,8 @@ protected static boolean problemIsFatal(List<Problem>
problems) {
return false;
}
- private static final int RETRIES = 3;
+// private static final int RETRIES = 3;
+ private static final int RETRIES = 1;
Review Comment:
This needs more investigation.
The stability of some tests may have to do with not using proper (new)
temporary directories.
In the places where I looked, the temp files and directories were made
inside the build tree. I would place them
outside the build tree, like in /tmp. The later could then be placed on a
fast or even virtual device for speed up.
I will set it back to 3.
In a future version, I would advise to make it a non-static field, that
individual subclasses or individual tests can set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
