neilcsmith-net commented on code in PR #8194:
URL: https://github.com/apache/netbeans/pull/8194#discussion_r1932645892
##########
enterprise/web.monitor/src/org/netbeans/modules/web/monitor/client/TransactionView.java:
##########
@@ -310,8 +310,8 @@ public void actionPerformed(ActionEvent e) {
}
}});
- timeDButton = new JToggleButton(new ImageIcon(
-
TransactionView.class.getResource("/org/netbeans/modules/web/monitor/client/icons/timesortB.gif")),
true);
+ timeDButton = new JToggleButton(ImageUtilities.loadIcon(
+
"org/netbeans/modules/web/monitor/client/icons/timesortB.gif"), true);
Review Comment:
Yes, which is why I consider that almost every use of image loading without
localization is a bug. Not for localization, but for branding. If you really
want to address loadup speed, then reconsidering how the branding token is
applied might be worth looking at. But possibly difficult.
Mind you, I'm curious if we have classloader trees why we also need the
branding (or even localization) suffixes as well?!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
