mbien commented on issue #8207: URL: https://github.com/apache/netbeans/issues/8207#issuecomment-2620166391
since the point was brought up that all (or most) icons should be loaded with localized=true: I don't have anything against this, but please wait a bit with this change till things settled. The localized code path is more complex and has more indirections, lets not change too many things at once ;) (there is also some potential for a cleanup of `ImageUtilities` impl before more things are changed - have something in my stash, planning to open a PR at some point) regarding image loading performance: it is something worth having an eye on, but me measuring https://github.com/apache/netbeans/pull/8194#discussion_r1931599731 didn't mean that i felt performance was insufficient. It also doesn't even mean that it influences startup, the bottleneck could be somewhere else and this happens in parallel decoupled from the bottleneck. Lets balance complexity with effect - there is a chance that everything will be still fine even after everything calls into `ImageUtilities` (uses localization) and without extra optimizations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
