Re: [PR] PHP 8.4 Support: Property hooks [netbeans]

[via GitHub]

junichi11 commented on code in PR #8227:
URL: https://github.com/apache/netbeans/pull/8227#discussion_r1948137829


##########
php/php.editor/src/org/netbeans/modules/php/editor/csl/NavigatorScanner.java:
##########
@@ -621,6 +634,13 @@ public String getHtml(HtmlFormatter formatter) {
             return formatter.getText();
         }
 
+        @Override
+        public boolean isCollapsedByDefault() {
+            // CSL has a bug
+            // if "Show inherited members" filter button is clicked, all nodes 
are expanded...
+            return true;
+        }

Review Comment:
   I think fields should be collapsed by default. However, there is a bug 
currently:
   
   
![nb-php84-property-hooks-csl-bug](https://github.com/user-attachments/assets/9bc0c500-845b-47e6-9a42-3b5ea120a9e6)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists