mbien commented on code in PR #8200:
URL: https://github.com/apache/netbeans/pull/8200#discussion_r1955158955
##########
ide/defaults/src/org/netbeans/modules/defaults/mf-layer.xml:
##########
@@ -1096,93 +1096,181 @@
<attr name="originalFile"
stringvalue="Actions/Edit/org-openide-actions-UndoAction.instance"/>
</file>
</folder>
+ <folder name="VSCode">
+ <attr name="SystemFileSystem.localizingBundle"
stringvalue="org.vscode.defaults.Bundle"/>
Review Comment:
this needs to be `org.netbeans.modules.defaults.Bundle`
```
Cannot load org.vscode.defaults.Bundle for
MultiFileObject@3bbce25e[Keymaps/VSCode] defined by
[jar:file:/run/media/mbien/500GB%20860EVO/nb_data/dl/13313143338/netbeans/ide/modules/org-netbeans-modules-defaults.jar!/org/netbeans/modules/defaults/mf-layer.xml]
Caused: java.util.MissingResourceException: No such bundle
org.vscode.defaults.Bundle
at org.openide.util.NbBundle.getBundle(NbBundle.java:438)
at org.openide.util.NbBundle.getBundle(NbBundle.java:370)
[catch] at
org.netbeans.modules.openide.filesystems.FileSystemStatus.annotateName(FileSystemStatus.java:71)
at
org.netbeans.modules.openide.filesystems.FileSystemStatus.annotateName(FileSystemStatus.java:58)
at
org.netbeans.modules.options.keymap.LayersBridge.refreshKeymapNames(LayersBridge.java:241)
at
org.netbeans.modules.options.keymap.LayersBridge.getProfiles(LayersBridge.java:262)
at
org.netbeans.modules.options.keymap.KeymapModel$PL.run(KeymapModel.java:230)
at
org.netbeans.modules.options.keymap.KeymapModel.waitFinished(KeymapModel.java:744)
at
org.netbeans.modules.options.keymap.KeymapModel.ensureProfilesLoaded(KeymapModel.java:314)
at
org.netbeans.modules.options.keymap.KeymapModel.getCurrentProfile(KeymapModel.java:394)
at
org.netbeans.modules.options.keymap.MutableShortcutsModel.getCurrentProfile(MutableShortcutsModel.java:181)
at
org.netbeans.modules.options.keymap.KeymapPanel.refreshProfileCombo(KeymapPanel.java:391)
at
org.netbeans.modules.options.keymap.KeymapPanel.update(KeymapPanel.java:359)
at
org.netbeans.modules.options.keymap.KeymapPanelController.update(KeymapPanelController.java:50)
at
org.netbeans.modules.options.CategoryModel$Category.update(CategoryModel.java:369)
at
org.netbeans.modules.options.OptionsPanel.setCurrentCategory(OptionsPanel.java:229)
at
org.netbeans.modules.options.OptionsPanel.access$300(OptionsPanel.java:99)
at
org.netbeans.modules.options.OptionsPanel$CategoryButton.mouseReleased(OptionsPanel.java:1264)
at
java.desktop/java.awt.Component.processMouseEvent(Component.java:6621)
at
java.desktop/javax.swing.JComponent.processMouseEvent(JComponent.java:3404)
```
##########
ide/defaults/src/org/netbeans/modules/defaults/VSCode-keybindings.xml:
##########
@@ -0,0 +1,112 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+
+
+
+<!DOCTYPE bindings PUBLIC "-//NetBeans//DTD Editor KeyBindings settings
1.1//EN" "http://www.netbeans.org/dtds/EditorKeyBindings-1_1.dtd";>
+<bindings>
+ <!-- Basic editing -->
+ <bind actionName="cut-to-clipboard" key="C-X"/>
+ <bind actionName="copy-to-clipboard" key="C-C"/>
+ <bind actionName="paste-from-clipboard" key="C-V"/>
+ <bind actionName="move-selection-else-line-down" key="A-DOWN"/>
+ <bind actionName="move-selection-else-line-up" key="A-UP"/>
+ <bind actionName="copy-selection-else-line-down" key="SA-DOWN"/>
+ <bind actionName="copy-selection-else-line-up" key="SA-UP"/>
+ <bind actionName="remove-line" key="CS-K"/>
+ <bind actionName="start-new-line" key="C-ENTER"/>
+ <bind actionName="insert-break-above" key="CS-ENTER"/>
+ <bind actionName="match-brace" key="CS-BACK_SLASH"/>
+ <bind actionName="indent" key="C-CLOSE_BRACKET"/>
+ <bind actionName="unindent" key="C-OPEN_BRACKET"/>
+ <bind actionName="caret-begin-line" key="HOME"/>
+ <bind actionName="caret-end-line" key="END"/>
+ <bind actionName="caret-begin" key="C-HOME"/>
+ <bind actionName="caret-end" key="C-END"/>
+ <bind actionName="scroll-up" key="C-UP"/>
+ <bind actionName="scroll-down" key="C-DOWN"/>
+ <bind actionName="page-up" key="A-PAGE_UP"/>
+ <bind actionName="page-down" key="A-PAGE_DOWN"/>
+
+ <!-- Code folding -->
+ <bind actionName="collapse-fold" key="CS-OPEN_BRACKET"/>
+ <bind actionName="expand-fold" key="CS-CLOSE_BRACKET"/>
+ <bind actionName="collapse-all-folds" key="C-K C-OPEN_BRACKET"/>
+ <bind actionName="expand-all-folds" key="C-K C-CLOSE_BRACKET"/>
+
+ <!-- Comments -->
+ <bind actionName="toggle-comment" key="C-SLASH"/>
+ <bind actionName="toggle-comment" key="C-K C-C"/>
+ <bind actionName="remove-comment" key="C-K C-U"/>
+ <bind actionName="toggle-block-comment" key="SA-A"/>
+
+ <!-- Search and navigation -->
+ <bind actionName="find" key="C-F"/>
+ <bind actionName="replace" key="C-H"/>
+ <bind actionName="find-next" key="F3"/>
+ <bind actionName="find-previous" key="S-F3"/>
+ <bind actionName="find-selection" key="C-F3"/>
+ <bind actionName="goto" key="C-G"/>
+ <bind actionName="goto-declaration" key="F12"/>
+ <bind actionName="goto-source" key="A-F12"/>
+ <bind actionName="goto-implementation" key="C-F12"/>
+
+ <!-- Multi-cursor and selection -->
+ <bind actionName="select-word" key="C-D"/>
+ <bind actionName="select-next-parameter" key="C-L"/>
+ <bind actionName="select-all" key="C-A"/>
+ <bind actionName="selection-grow" key="SA-RIGHT"/>
+ <bind actionName="selection-shrink" key="SA-LEFT"/>
+
+ <!-- Editor management -->
+ <bind actionName="close" key="C-F4"/>
+ <bind actionName="close" key="C-W"/>
+ <bind actionName="split-editor" key="C-BACK_SLASH"/>
+
+ <!-- Rich language features -->
+ <bind actionName="completion-show" key="C-SPACE"/>
+ <bind actionName="completion-show" key="C-I"/>
+ <bind actionName="parameter-hints-show" key="CS-SPACE"/>
+ <bind actionName="format" key="SA-F"/>
+ <bind actionName="fix-imports" key="C-DOT"/>
+
+ <!-- Refactoring -->
+ <bind actionName="rename" key="F2"/>
+ <bind actionName="refactor-quickmenu" key="C-DOT"/>
Review Comment:
`C-DOT` doesn't appear to be a valid keystroke, what would work is `C-PERIOD`
also: the same keystroke is used for two refactoring actions which is not
ideal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
