junichi11 commented on code in PR #8227:
URL: https://github.com/apache/netbeans/pull/8227#discussion_r1956957230
##########
php/php.editor/src/org/netbeans/modules/php/editor/api/PhpModifiers.java:
##########
@@ -132,8 +132,8 @@ private PhpModifiers(int... bitmask) {
for (int mode : bitmask) {
this.mod |= mode;
}
- if (!Modifier.isPrivate(mod) && !Modifier.isProtected(mod) &&
!Modifier.isImplicitPublic(mod)) {
- mod |= Modifier.PUBLIC;
+ if (!Modifier.isPrivate(mod) && !Modifier.isProtected(mod) &&
!Modifier.isPublic(mod)) {
+ mod |= Modifier.IMPLICIT_PUBLIC;
}
Review Comment:
`IMPLICIT_PUBLIC` is better if `mod` is `0` because the public modifier
doesn't exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
