errael commented on PR #8253: URL: https://github.com/apache/netbeans/pull/8253#issuecomment-2661653578
Some open issues/questions about this PR. PR draft until these are answered. Should default to JUL if J8 or earlier. How to get the project's java version? Is it OK to use "java.lang.System.Logger" directly? This is because ``` System.Logger.class.getName() is "java.lang.System$Logger", note '$', and "...getQualifiedName().contentEquals" fails, so use litteral class name. ``` `Generate > Logger...` requires knowing which kind of logger. That information is only specified in `Hints > ErrorFixes > SurroundWithTryCatch`. It's weird to be looking into the hints this way, but otherwise some entirely new UI is required. The PR uses FileHintPreferences to grab this info, I've never used it before so this code should be carefully reviewed. Is //NOI18N still used/needed? MaigicSurroundWithTryCatchFix is mixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
