jkovalsky commented on PR #72: URL: https://github.com/apache/netbeans-tools/pull/72#issuecomment-2675033086
I finally found some time on my way home from Prague today and tested the two improvements. I have to say that I like both modifications and agree that for plugin owners it will be a great relief. Not only I tested the main happy flows, but also some corner case such as: - if plugin has version 3.0 verified for NetBeans 11.2 and requests verification for its new version 3.1 in NetBeans 11.3, the verification is not auto-approved - if plugin has version 3.0 verified for NetBeans 11.2, request for verification of its new version 3.1 in NetBeans 11.3 was auto-approved, then verification request for version 3.1 in NetBeans 11.3 follow the old human interaction process and when that is approved the old version 3.0 is replaced by version 3.1 In the code I would just suggest to introduce some login preventing from publishing two different versions in plugin catalog for 1 NetBeans version. Please see current state of NetBeans serial version uid generator plugin. Besides that I noticed that automatic re-generation of module catalogs was broken (or is not set), so I had to invoke it manually after approving some verification request. In addition to that I also spotted that verification details only contain creation records, but no approval records. I guess it is because I was using the Master GO @matthiasblaesing, you have done a great job! If you address my version collision comment, I will be ready to approve your PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
