lahodaj commented on PR #8260: URL: https://github.com/apache/netbeans/pull/8260#issuecomment-2682351929
I have seen some fairly frequent deadlocks on start with the original patch. I don't think it was directly caused by the change here, as I think I've seen a deadlock like that even before, but this change might have made the deadlock much more probable. The deadlock was Project mutex -> SourceImpl monitor (when the project properties were set) vs SourceImpl monitor -> Project mutex computing the roots, and querying the properties. The solution for the deadlock proposed here is to only record something changed when the poperties change, and compute on the first access, and limit locking when computing the roots. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
