mbien commented on code in PR #8231:
URL: https://github.com/apache/netbeans/pull/8231#discussion_r1985332354
##########
ide/editor.settings.storage/src/org/netbeans/modules/editor/settings/storage/SettingsProvider.java:
##########
@@ -146,39 +146,32 @@ public void propertyChange(PropertyChangeEvent evt) {
synchronized (this) {
boolean fcsChanged = false;
boolean kbsChanged = false;
-
-// if (mimePath.getPath().contains("xml")) {
-// System.out.println("@@@ propertyChange: mimePath = " +
mimePath.getPath() + " profile = " + fcsProfile + " property = " +
evt.getPropertyName() + " oldValue = " + (evt.getOldValue() instanceof MimePath
? ((MimePath) evt.getOldValue()).getPath() : evt.getOldValue()) + " newValue =
" + evt.getNewValue());
-// }
// Determine what has changed
+ String prop = evt.getPropertyName();
if (this.kbsi == evt.getSource()) {
kbsChanged = true;
-
- } else if (evt.getPropertyName() == null) {
+ } else if (prop == null) {
Review Comment:
nothing against it, but it would reformat a big section which would make
reviews more difficult and might risk to hide the change in it. The main reason
I extracted the prop name is because it would make the added `||` longer a few
lines later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
