mbien commented on code in PR #8264:
URL: https://github.com/apache/netbeans/pull/8264#discussion_r1997221701
##########
java/lib.jshell.agent/build.xml:
##########
@@ -55,20 +55,6 @@
</target>
<target name="jar-probe" depends="probe-init">
- <unjar src="${agentsrc.jshell.cp}" dest="build/agent/classes">
- <patternset>
- <include name="jdk/jshell/execution/**"/>
- <exclude name="**/JDI*.class"/>
- <exclude name="**/LocalExecutionControl.class"/>
- <exclude name="**/StreamingExecutionControl.class"/>
- <!--<exclude name="**/DemultiplexInput.class"/>-->
- </patternset>
- <patternset>
- <include name="jdk/jshell/spi/ExecutionControl*.class"/>
- <exclude
name="jdk/jshell/spi/ExecutionControl*Generator.class"/>
- <include name="jdk/jshell/spi/SPIResolutionException.class"/>
- </patternset>
- </unjar>
Review Comment:
makes sense. I might revert this to the original version
https://github.com/apache/netbeans/commit/5a05442bdd1d9caf1ae878f007fcc78638f67660
and play with it a bit more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
