neilcsmith-net commented on PR #8361: URL: https://github.com/apache/netbeans/pull/8361#issuecomment-2758907935
Thanks for the detailed responses. > You can disable the code via config (see the system properties) and remove the module. If you insist, I can add a "--disable-nb-agent" option to the launchers. The system property disables the transformation, not the agent? Module removal requires the IDE location to be modifiable, which is not always the case. I think we need the ability for people to switch this on or off easily in case of issues, either with it or to rule it out. I'm also not sure yet that we want it enabled by default in the cross-platform zip. Launcher updates are something of a PITA, so we should consider how the launcher changes can cover various eventualities. Ideally in my opinion we'd have something like an `--agent` option that could perhaps take `none`, `default` or a full path as an argument. Path could be useful for end user testing at a later date. Like `--userdir`, etc. latest specified wins - setting on CLI or shortcut overrides conf. Default in the launcher should be off in my opinion, and controlled by the default options. Could be other way around. Decision on enabling by default in the zip should happen after we've had some rc testing, but would be done via default options. > > -1 to registering NBClipboard by default or without easy override. Its removal fixed as much as it broke ... > I don't remember where I got that that from, but I think I remember, you asking for it. Anyway, I'm not tied to this, not sure, why the security manager approach was more acceptable or how you intent to solve it differently. Yes, I suggested it as an option for testing, because we know it has side effects. The security manager approach was not more acceptable. When we talked about its removal, there was various discussion about the clipboard. What was interesting is that removing it fixed other things, like copy&paste in the file trees. > What do you have in mind? I now have a virtual machine that can reliably reproduce the problem. I still don't know what changed in that machine, but I used it to verify the change (problem visible without agent, problem gone with it). When xxDark mentioned the JDK issue he said it was only triggered with registered flavor listeners. We're not using them in many places https://github.com/search?q=repo%3Aapache%2Fnetbeans+flavorlistener&type=code I think registering just in `NbClipboard` and `ExplorerActionsImpl`? If commenting out adding them to the system clipboard stops the bug occurring, it's possible we might look at something different? Particularly given NbClipboard is already partially disconnected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
