errael commented on code in PR #8253:
URL: https://github.com/apache/netbeans/pull/8253#discussion_r2019588672


##########
java/java.editor/src/org/netbeans/modules/java/editor/codegen/LoggerGenerator.java:
##########
@@ -152,15 +164,66 @@ public void run(WorkingCopy copy) throws IOException {
         }
     }
 
+    public static String getBaseLoggerName() {
+        // // Undocumented feature/property subject to change/removal. Need a 
UI.
+        // String name = 
System.getProperty("LOGGER_GENERATOR_BASE_LOGGER_NAME");
+        // return name == null ? "LOG" : name;
+        return "LOG";
+    }

Review Comment:
   > if we want to parametrize this, should this be project level configurable?
   
   If there's follow up work, I'd be inclined to add it to the rest of logging 
configuration
   ```
   ...java.hints.errors.ErrorFixesFakeHintSURROUND_WITH_TRY_CATCH
   ```
   which makes it project configurable. Probably rename it to indicate it's 
general logging stuff, and include additional stuff as needed.
   
   Fixed comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to