haidubogdan commented on PR #8367: URL: https://github.com/apache/netbeans/pull/8367#issuecomment-2764620025
> Apart from the two remaining comments from yesterday, I forgot to add: > > * the `javascript2.vue` module should be added to the dependency list of `javascript2.kit`, so that it gets activated together with it > * the spec versions of the modules, that gained changed friends, should be bumped (yeah I know this is under discussion, but we are still weaks from branch point, so should not be problematic). Ah, yes, my bad, I got inspired from "jade" implementation, and I included `webcommon`, and `css.editor` without checking if it's really used. I've removed them + removed the used friend dependencies spec version. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
