mbien commented on code in PR #8391:
URL: https://github.com/apache/netbeans/pull/8391#discussion_r2032164626
##########
platform/openide.dialogs/src/org/openide/NotifyDescriptor.java:
##########
@@ -129,24 +129,45 @@ public class NotifyDescriptor extends Object {
*/
public static final String PROP_INFO_NOTIFICATION = "infoNotification"; //
NOI18N
+ /**
Review Comment:
this doesn't work since two options (`JOptionPane.YES_OPTION` and
`JOptionPane.OK_OPTION`) would have the same int value which would return the
same Integer instance due to the `vlaueOf()` cache (also used by auto boxing).
Two return options with the same identity would be an incompatible change. This
fails several tests across NB (already tried with
https://github.com/apache/netbeans/pull/8391#discussion_r2027026494).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
