mbien commented on PR #8407: URL: https://github.com/apache/netbeans/pull/8407#issuecomment-2790113170
> OK, I'm struggling to understand the requirement for the complexity here? compatibility. I have been accused of over engineering already (which I don't take lightly :P) but the first attempt was obviously to simply use `Integer.valueOf()`. This creates the situation that two return options having the same identity (which is not compatible) - this failed multiple tests only indirectly related to the module - this is never a good sign. You can also easily come up with code where someone uses `==` if chains and would get a different result after such change. But I am open for suggestions of course. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
