mbien commented on PR #8361: URL: https://github.com/apache/netbeans/pull/8361#issuecomment-2808845644
> Haven't really looked at the emitted bytecode > this all will be hopefully only needed temporary to elaborate a bit: since we essentially need static bytecode injection for the purpose of patching (to swap out a method essentially), verification would be conceptually easy, since all it would have to proof is that the emitted bytecode matches javac bytecode. I tested this [here](https://github.com/mbien/agentclippy/blob/master/src/test/java/dev/mbien/agentclippy/AgentClippyTest.java) ([mail](https://lists.apache.org/thread/b8xfk6omk9g0yqsf0lj9zps9scydjfy9)). But since this is hopefully only needed until the JDK is patched and the agent would also disable itself on failure (+ option to edit the launch config), I think this is good to go. (thats why I approved - there is also no time left for changes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
