jglick commented on code in PR #8433:
URL: https://github.com/apache/netbeans/pull/8433#discussion_r2052390349
##########
java/maven.junit/src/org/netbeans/modules/maven/junit/JUnitOutputListenerProvider.java:
##########
@@ -316,7 +316,13 @@ static boolean isFullJavaId(String
possibleNewRunningTestClass) {
}
if (null != outputDir) {
createSession(outputDir);
-
project2outputDirs.put(visitor.getContext().getCurrentProject(), outputDir);
+ OutputVisitor.Context context = visitor.getContext();
+ if (context != null) {
+ Project currentProject = context.getCurrentProject();
+ if (currentProject != null) {
Review Comment:
https://github.com/apache/netbeans/blob/98e53cd28b74dc286142ca182bd6e7d885322496/java/maven/src/org/netbeans/modules/maven/api/output/OutputVisitor.java#L43
is not `final` so the current idiom seems safer in the face of potential
concurrent modifications.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
